Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Flush operation before create index #598

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

congqixia
Copy link
Contributor

@congqixia congqixia commented Oct 16, 2023

See also #594
sync behavior with pymilvus
/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Oct 16, 2023
@sre-ci-robot sre-ci-robot requested review from sunby and yah01 October 16, 2023 03:53
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/S Denotes a PR that changes 10-29 lines. labels Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #598 (6503c24) into master (b1c9ccb) will decrease coverage by 0.07%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
- Coverage   82.92%   82.85%   -0.07%     
==========================================
  Files          40       40              
  Lines        3643     3640       -3     
==========================================
- Hits         3021     3016       -5     
- Misses        511      512       +1     
- Partials      111      112       +1     
Files Coverage Δ
client/index.go 77.60% <ø> (-0.53%) ⬇️

... and 1 file with indirect coverage changes

@mergify mergify bot added the ci-passed auto merge needed label label Oct 16, 2023
@yah01
Copy link
Member

yah01 commented Oct 16, 2023

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Oct 16, 2023
@sre-ci-robot sre-ci-robot merged commit 7c1baef into milvus-io:master Oct 16, 2023
6 checks passed
@congqixia congqixia deleted the remove_flush_createindex branch October 16, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants