-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bulkinsert options #640
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jaime0815 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #640 +/- ##
==========================================
- Coverage 74.95% 74.02% -0.94%
==========================================
Files 44 44
Lines 4125 4177 +52
==========================================
Hits 3092 3092
- Misses 921 973 +52
Partials 112 112
|
e3dad37
to
dd928d7
Compare
func WithBucket(bucket string) BulkInsertOption { | ||
return func(req *milvuspb.ImportRequest) { | ||
optionMap := entity.KvPairsMap(req.GetOptions()) | ||
optionMap["bucket"] = bucket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bucketName
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
params.add("address", "localhost")
params.add("port", 9000)
params.add("accessKeyID", "minioadmin")
params.add("secretAccessKey", "minioadmin")
params.add("useSSL", False)
params.add("bucketName", "a-bucket")
params.add("rootPath", "files")
params.add("useIAM", False)
params.add("cloudProvider", "aliyun")
params.add("iamEndpoint", "")
params.add("region", "")
params.add("useVirtualHost", True)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bucket is an already existing name, it can't be compatible with old version if we change it
Signed-off-by: jaime <[email protected]>
dd928d7
to
94e7369
Compare
No description provided.