Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bulkinsert options #640

Closed
wants to merge 1 commit into from

Conversation

jaime0815
Copy link
Contributor

No description provided.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaime0815
To complete the pull request process, please assign yah01 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yah01 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (43226a3) 74.95% compared to head (94e7369) 74.02%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #640      +/-   ##
==========================================
- Coverage   74.95%   74.02%   -0.94%     
==========================================
  Files          44       44              
  Lines        4125     4177      +52     
==========================================
  Hits         3092     3092              
- Misses        921      973      +52     
  Partials      112      112              
Files Coverage Δ
client/options.go 34.10% <0.00%> (-23.04%) ⬇️

client/options.go Outdated Show resolved Hide resolved
func WithBucket(bucket string) BulkInsertOption {
return func(req *milvuspb.ImportRequest) {
optionMap := entity.KvPairsMap(req.GetOptions())
optionMap["bucket"] = bucket
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bucketName

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

params.add("address", "localhost")
params.add("port", 9000)
params.add("accessKeyID", "minioadmin")
params.add("secretAccessKey", "minioadmin")
params.add("useSSL", False)
params.add("bucketName", "a-bucket")
params.add("rootPath", "files")
params.add("useIAM", False)
params.add("cloudProvider", "aliyun")
params.add("iamEndpoint", "")
params.add("region", "")
params.add("useVirtualHost", True)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bucket is an already existing name, it can't be compatible with old version if we change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants