Add merr package to utilize milvus error #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Congqi Xia <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind improvement |
sre-ci-robot
added
kind/improvement
Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
added
size/XXL
Signed-off-by: Congqi Xia <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #645 +/- ##
==========================================
- Coverage 74.95% 73.29% -1.67%
==========================================
Files 44 46 +2
Lines 4125 4272 +147
==========================================
+ Hits 3092 3131 +39
- Misses 921 1028 +107
- Partials 112 113 +1
|
|
/lgtm |
congqixia
added a commit
to congqixia/milvus-sdk-go
that referenced
this pull request
Jan 10, 2024
This PR: - Bump version to 2.4.0-dev - Add merr package, which is simplified version from milvus main repo - Add mock API due to proto update --------- Signed-off-by: Congqi Xia <[email protected]>
congqixia
added a commit
to congqixia/milvus-sdk-go
that referenced
this pull request
Jan 16, 2024
This PR: - Bump version to 2.4.0-dev - Add merr package, which is simplified version from milvus main repo - Add mock API due to proto update --------- Signed-off-by: Congqi Xia <[email protected]>
congqixia
added a commit
to congqixia/milvus-sdk-go
that referenced
this pull request
Jan 17, 2024
This PR: - Bump version to 2.4.0-dev - Add merr package, which is simplified version from milvus main repo - Add mock API due to proto update --------- Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jan 17, 2024
#648) This PR: - Add merr package, which is simplified version from milvus main repo - Add mock API due to proto update --------- --------- Signed-off-by: Congqi Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: