Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support random sample #39532

Merged
merged 22 commits into from
Feb 18, 2025
Merged

Conversation

SpadeA-Tang
Copy link
Contributor

@SpadeA-Tang SpadeA-Tang commented Jan 23, 2025

issue: #39541

This PR implements random sample, the syntax is:

filter="random_sample(factor)"
or 
filter="boolean_expression && random_sample(factor)"

where 
factor is a float between (0, 1) and 
boolean_expression is like
 "1 <= number < 10", "color in ["read, "blue"]" or others

…for expr in proxy module, 2. polish code and make enure the correctness, 3. add tests

Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
@SpadeA-Tang SpadeA-Tang marked this pull request as draft January 23, 2025 02:11
@sre-ci-robot sre-ci-robot added do-not-merge/work-in-progress Don't merge even CI passed. size/XXL Denotes a PR that changes 1000+ lines. area/compilation labels Jan 23, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jan 23, 2025
Copy link
Contributor

mergify bot commented Jan 23, 2025

@SpadeA-Tang Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 82.29167% with 34 lines in your changes missing coverage. Please review.

Project coverage is 79.80%. Comparing base (9bbaaac) to head (7f3f140).
Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/query/PlanProto.cpp 45.45% 12 Missing ⚠️
internal/parser/planparserv2/parser_visitor.go 84.21% 6 Missing and 3 partials ⚠️
internal/core/src/exec/operator/RandomSampleNode.h 60.00% 4 Missing ⚠️
internal/core/src/plan/PlanNode.h 66.66% 4 Missing ⚠️
...ternal/core/src/exec/operator/RandomSampleNode.cpp 96.15% 3 Missing ⚠️
...ernal/parser/planparserv2/fill_expression_value.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39532      +/-   ##
==========================================
- Coverage   80.10%   79.80%   -0.30%     
==========================================
  Files        1488     1498      +10     
  Lines      205586   207161    +1575     
==========================================
+ Hits       164687   165333     +646     
- Misses      34958    35833     +875     
- Partials     5941     5995      +54     
Components Coverage Δ
Client 79.24% <ø> (ø)
Core 69.62% <82.70%> (+0.23%) ⬆️
Go 81.47% <83.07%> (-0.37%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/bitset/common.h 94.11% <100.00%> (ø)
internal/core/src/exec/Driver.cpp 81.81% <100.00%> (+0.42%) ⬆️
...e/src/exec/expression/BinaryArithOpEvalRangeExpr.h 100.00% <100.00%> (ø)
...ernal/parser/planparserv2/fill_expression_value.go 85.40% <0.00%> (-0.94%) ⬇️
...ternal/core/src/exec/operator/RandomSampleNode.cpp 96.15% <96.15%> (ø)
internal/core/src/exec/operator/RandomSampleNode.h 60.00% <60.00%> (ø)
internal/core/src/plan/PlanNode.h 53.65% <66.66%> (+1.40%) ⬆️
internal/parser/planparserv2/parser_visitor.go 86.00% <84.21%> (-0.22%) ⬇️
internal/core/src/query/PlanProto.cpp 85.79% <45.45%> (-2.78%) ⬇️

... and 177 files with indirect coverage changes

Signed-off-by: SpadeA-Tang <[email protected]>
@SpadeA-Tang SpadeA-Tang marked this pull request as ready for review January 23, 2025 06:21
@sre-ci-robot sre-ci-robot removed the do-not-merge/work-in-progress Don't merge even CI passed. label Jan 23, 2025
Copy link
Contributor

mergify bot commented Jan 23, 2025

@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 23, 2025

@SpadeA-Tang cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 23, 2025

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

Signed-off-by: SpadeA-Tang <[email protected]>
Copy link
Contributor

mergify bot commented Jan 24, 2025

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SpadeA-Tang
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 24, 2025

@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SpadeA-Tang
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Feb 5, 2025

@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SpadeA-Tang
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Feb 6, 2025
@mergify mergify bot removed the ci-passed label Feb 14, 2025
Signed-off-by: SpadeA <[email protected]>
Copy link
Contributor

mergify bot commented Feb 14, 2025

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 17, 2025

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SpadeA-Tang
Copy link
Contributor Author

rerun go-sdk

@czs007
Copy link
Collaborator

czs007 commented Feb 17, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SpadeA-Tang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented Feb 18, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Feb 18, 2025
@sre-ci-robot sre-ci-robot merged commit 0dc21f0 into milvus-io:master Feb 18, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants