Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: improve sort performance by writing with batch record #39685

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Feb 7, 2025

See #37234

@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. labels Feb 7, 2025
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby February 7, 2025 08:12
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 7, 2025
Copy link
Contributor

mergify bot commented Feb 7, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.39%. Comparing base (427b6a4) to head (c6d8a0f).
Report is 17 commits behind head on master.

❌ Your project check has failed because the head coverage (69.39%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #39685   +/-   ##
=======================================
  Coverage   69.39%   69.39%           
=======================================
  Files         302      302           
  Lines       27070    27077    +7     
=======================================
+ Hits        18785    18790    +5     
- Misses       8285     8287    +2     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.39% <ø> (+<0.01%) ⬆️
Go ∅ <ø> (∅)

see 1 file with indirect coverage changes

Signed-off-by: Ted Xu <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Feb 7, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu
Copy link
Contributor Author

tedxu commented Feb 10, 2025

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Feb 10, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants