Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add phrase match testcases #39689

Merged
merged 4 commits into from
Feb 10, 2025
Merged

test: add phrase match testcases #39689

merged 4 commits into from
Feb 10, 2025

Conversation

zhuwenxing
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Feb 7, 2025
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/test sig/testing labels Feb 7, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/test labels Feb 7, 2025
@zhuwenxing zhuwenxing force-pushed the add_phrase_match_test branch from aa4f26a to 4a7b991 Compare February 7, 2025 10:32
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 7, 2025

@zhuwenxing Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. dco-passed DCO check passed. and removed dco-passed DCO check passed. needs-dco DCO is missing in this pull request. labels Feb 7, 2025
@zhuwenxing zhuwenxing force-pushed the add_phrase_match_test branch from 4a7b991 to 5a3f50f Compare February 7, 2025 10:33
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 7, 2025

@zhuwenxing E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhuwenxing
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 8, 2025

@zhuwenxing E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Feb 10, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 10, 2025

@zhuwenxing go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Feb 10, 2025
@zhuwenxing
Copy link
Contributor Author

rerun go-sdk

@yanliang567
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yanliang567, zhuwenxing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 13cffaf into milvus-io:master Feb 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binbinlv binbinlv Awaiting requested review from binbinlv

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@yanliang567 yanliang567

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor kind/test lgtm sig/testing size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhuwenxing @yanliang567 @sre-ci-robot