Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AlterCollection unable to modify ConsistencyLevel #39708

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Feb 8, 2025

fix: AlterCollection unable to modify ConsistencyLevel
issue: #39707

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Feb 8, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JsDove
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 8, 2025
Signed-off-by: Xianhui.Lin <[email protected]>

fix

Signed-off-by: Xianhui.Lin <[email protected]>
@JsDove JsDove force-pushed the fix-alterConsistency branch from 22bcdbd to e66df5c Compare February 8, 2025 08:24
Copy link
Contributor

mergify bot commented Feb 8, 2025

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Feb 8, 2025

rerun go-sdk

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.15%. Comparing base (cd56d64) to head (e66df5c).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
internal/rootcoord/alter_collection_task.go 75.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39708       +/-   ##
===========================================
+ Coverage   69.39%   80.15%   +10.76%     
===========================================
  Files         302     1476     +1174     
  Lines       27077   204342   +177265     
===========================================
+ Hits        18790   163794   +145004     
- Misses       8287    34704    +26417     
- Partials        0     5844     +5844     
Components Coverage Δ
Client 79.44% <ø> (∅)
Core 69.39% <ø> (ø)
Go 81.89% <80.95%> (∅)
Files with missing lines Coverage Δ
internal/rootcoord/create_collection_task.go 90.54% <100.00%> (ø)
internal/rootcoord/alter_collection_task.go 54.57% <75.00%> (ø)

... and 1172 files with indirect coverage changes

@JsDove
Copy link
Contributor Author

JsDove commented Feb 10, 2025

rerun ut

1 similar comment
@JsDove
Copy link
Contributor Author

JsDove commented Feb 11, 2025

rerun ut

@mergify mergify bot added the ci-passed label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants