Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] root check the role list if rootShouldBindRole is true #39714

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Feb 8, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 8, 2025
Copy link
Contributor

mergify bot commented Feb 8, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 8, 2025

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (4a8e6fc) to head (3d49955).
Report is 3 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.5   #39714   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files        1415     1415           
  Lines      198870   198876    +6     
=======================================
+ Hits       161138   161148   +10     
  Misses      32066    32066           
+ Partials     5666     5662    -4     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.46% <ø> (ø)
Go 82.99% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/rootcoord/list_db_task.go 100.00% <100.00%> (ø)
internal/rootcoord/root_coord.go 90.14% <100.00%> (ø)
internal/rootcoord/show_collection_task.go 100.00% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.35% <100.00%> (+<0.01%) ⬆️

... and 34 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 8, 2025
@SimFG
Copy link
Contributor Author

SimFG commented Feb 10, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Feb 10, 2025

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Feb 10, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Feb 10, 2025

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f542c86 into milvus-io:2.5 Feb 11, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants