-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [2.5] root check the role list if rootShouldBindRole
is true
#39714
Conversation
@SimFG E2e jenkins job failed, comment |
Signed-off-by: SimFG <[email protected]>
@SimFG go-sdk check failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #39714 +/- ##
=======================================
Coverage 81.02% 81.02%
=======================================
Files 1415 1415
Lines 198870 198876 +6
=======================================
+ Hits 161138 161148 +10
Misses 32066 32066
+ Partials 5666 5662 -4
|
rerun go-sdk |
@SimFG go-sdk check failed, comment |
rerun go-sdk |
@SimFG go-sdk check failed, comment |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SimFG, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
common.security.rootShouldBindRole
to true #39712rootShouldBindRole
is true #39713