Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] root check the role list if rootShouldBindRole is true #39715

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Feb 8, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 8, 2025
Copy link
Contributor

mergify bot commented Feb 8, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 10, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.46%. Comparing base (c33df02) to head (9302b84).
Report is 7 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #39715      +/-   ##
==========================================
- Coverage   83.39%   79.46%   -3.93%     
==========================================
  Files         812     1080     +268     
  Lines      143791   170237   +26446     
==========================================
+ Hits       119909   135279   +15370     
- Misses      19370    30439   +11069     
- Partials     4512     4519       +7     
Files with missing lines Coverage Δ
internal/rootcoord/list_db_task.go 100.00% <100.00%> (ø)
internal/rootcoord/root_coord.go 87.68% <100.00%> (ø)
internal/rootcoord/show_collection_task.go 100.00% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.40% <100.00%> (+<0.01%) ⬆️

... and 296 files with indirect coverage changes

@SimFG
Copy link
Contributor Author

SimFG commented Feb 10, 2025

rerun ut

@mergify mergify bot added the ci-passed label Feb 10, 2025
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7c046e7 into milvus-io:2.4 Feb 11, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants