-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [2.4] root check the role list if rootShouldBindRole
is true
#39715
Conversation
@SimFG E2e jenkins job failed, comment |
@SimFG E2e jenkins job failed, comment |
Signed-off-by: SimFG <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #39715 +/- ##
==========================================
- Coverage 83.39% 79.46% -3.93%
==========================================
Files 812 1080 +268
Lines 143791 170237 +26446
==========================================
+ Hits 119909 135279 +15370
- Misses 19370 30439 +11069
- Partials 4512 4519 +7
|
rerun ut |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SimFG, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
common.security.rootShouldBindRole
to true #39712rootShouldBindRole
is true #39713