Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] Add metrics for parse expression #39716

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

xiaocai2333
Copy link
Contributor

master pr: #39654

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign liliu-z after the PR has been reviewed.
You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Feb 8, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 8, 2025
Copy link
Contributor

mergify bot commented Feb 8, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (4a8e6fc) to head (8ebec56).

Files with missing lines Patch % Lines
internal/proxy/task_query.go 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39716      +/-   ##
==========================================
+ Coverage   81.02%   81.04%   +0.01%     
==========================================
  Files        1415     1415              
  Lines      198870   198885      +15     
==========================================
+ Hits       161138   161181      +43     
+ Misses      32066    32052      -14     
+ Partials     5666     5652      -14     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.46% <ø> (ø)
Go 83.01% <92.85%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/task_delete.go 90.33% <100.00%> (+0.07%) ⬆️
internal/proxy/task_search.go 76.59% <100.00%> (+0.08%) ⬆️
pkg/metrics/proxy_metrics.go 100.00% <100.00%> (ø)
internal/proxy/task_query.go 80.71% <83.33%> (+0.02%) ⬆️

... and 28 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants