Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: keep consistent of memory and meta of broadcaster #39721

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Feb 8, 2025

issue: #38399
pr: #39720

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Feb 8, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 8, 2025
Copy link
Contributor

mergify bot commented Feb 8, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (4a8e6fc) to head (6bb69c6).
Report is 1 commits behind head on 2.5.

Files with missing lines Patch % Lines
...treamingcoord/server/broadcaster/broadcast_task.go 98.21% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.5   #39721   +/-   ##
=======================================
  Coverage   81.02%   81.03%           
=======================================
  Files        1415     1415           
  Lines      198870   198889   +19     
=======================================
+ Hits       161138   161164   +26     
- Misses      32066    32067    +1     
+ Partials     5666     5658    -8     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.46% <ø> (ø)
Go 82.99% <98.21%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
...treamingcoord/server/broadcaster/broadcast_task.go 95.74% <98.21%> (+0.66%) ⬆️

... and 30 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 8, 2025
@chyezh
Copy link
Contributor Author

chyezh commented Feb 8, 2025

rerun ut

@chyezh
Copy link
Contributor Author

chyezh commented Feb 8, 2025

run go-sdk

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b936061 into milvus-io:2.5 Feb 10, 2025
19 of 20 checks passed
@chyezh chyezh deleted the fix_add_rollback_for_broadcast_ack_2_5 branch February 10, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants