Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: dump pprof info if component stop progress timeout #39726

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Feb 8, 2025

issue: #39735

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Feb 8, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 8, 2025
Copy link
Contributor

mergify bot commented Feb 8, 2025

@weiliu1031 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Feb 8, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 8, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.12%. Comparing base (664a8a2) to head (f70471f).
Report is 16 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39726       +/-   ##
===========================================
+ Coverage   69.39%   80.12%   +10.72%     
===========================================
  Files         302     1486     +1184     
  Lines       27077   205428   +178351     
===========================================
+ Hits        18790   164590   +145800     
- Misses       8287    34907    +26620     
- Partials        0     5931     +5931     
Components Coverage Δ
Client 79.27% <ø> (∅)
Core 69.39% <ø> (ø)
Go 81.85% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/distributed/utils/util.go 80.00% <100.00%> (ø)
pkg/util/paramtable/grpc_param.go 85.85% <100.00%> (ø)
pkg/util/paramtable/service_param.go 99.18% <100.00%> (ø)

... and 1181 files with indirect coverage changes

@weiliu1031
Copy link
Contributor Author

rerun ut

Copy link
Contributor

mergify bot commented Feb 10, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Feb 10, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Feb 10, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 10, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 10, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Feb 11, 2025
Signed-off-by: Wei Liu <[email protected]>
Copy link
Contributor

mergify bot commented Feb 13, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Feb 13, 2025
sre-ci-robot pushed a commit that referenced this pull request Feb 13, 2025
@czs007
Copy link
Collaborator

czs007 commented Feb 13, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 41dc1a7 into milvus-io:master Feb 13, 2025
20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants