Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Fix module for long type #39804

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

xiaocai2333
Copy link
Contributor

issue: #39640

master pr: #39722

Signed-off-by: Cai Zhang <[email protected]>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Feb 11, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Feb 11, 2025
Copy link
Contributor

mergify bot commented Feb 11, 2025

@xiaocai2333

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@czs007
Copy link
Collaborator

czs007 commented Feb 11, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.36%. Comparing base (655df8d) to head (2b8f928).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #39804      +/-   ##
==========================================
+ Coverage   79.44%   80.36%   +0.91%     
==========================================
  Files        1080     1080              
  Lines      170382   170405      +23     
==========================================
+ Hits       135364   136946    +1582     
+ Misses      30488    28933    -1555     
+ Partials     4530     4526       -4     
Files with missing lines Coverage Δ
internal/core/src/bitset/common.h 100.00% <100.00%> (ø)
...src/exec/expression/BinaryArithOpEvalRangeExpr.cpp 85.26% <ø> (ø)

... and 94 files with indirect coverage changes

@xiaocai2333 xiaocai2333 changed the title Fix module for long type fix: [2.4] Fix module for long type Feb 12, 2025
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Feb 12, 2025
Signed-off-by: Cai Zhang <[email protected]>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed lgtm size/S Denotes a PR that changes 10-29 lines. labels Feb 12, 2025
@czs007
Copy link
Collaborator

czs007 commented Feb 12, 2025

/lgtm

@mergify mergify bot added the ci-passed label Feb 12, 2025
@sre-ci-robot sre-ci-robot merged commit c8a7290 into milvus-io:2.4 Feb 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants