Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [skip e2e][2.5] pr conflict cause ut failed #39810

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

weiliu1031
Copy link
Contributor

Related to #39701 & #39681

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 12, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 12, 2025
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Feb 12, 2025

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 modified the milestones: 2.4.22, 2.5.5 Feb 12, 2025
@mergify mergify bot added ci-passed and removed ci-passed labels Feb 12, 2025
@mergify mergify bot added ci-passed and removed ci-passed labels Feb 12, 2025
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Feb 12, 2025
@sre-ci-robot sre-ci-robot merged commit 82dc57a into milvus-io:2.5 Feb 12, 2025
11 of 12 checks passed
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.88%. Comparing base (4322a0d) to head (0fe511e).
Report is 3 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #39810       +/-   ##
===========================================
+ Coverage   69.46%   82.88%   +13.41%     
===========================================
  Files         300     1115      +815     
  Lines       26798   172121   +145323     
===========================================
+ Hits        18616   142662   +124046     
- Misses       8182    23808    +15626     
- Partials        0     5651     +5651     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core ∅ <ø> (∅)
Go 83.06% <ø> (∅)

see 1415 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants