Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [2.5]return topks when search in restful v2 #39839

Merged
merged 1 commit into from
Feb 14, 2025
Merged

enhance: [2.5]return topks when search in restful v2 #39839

merged 1 commit into from
Feb 14, 2025

Conversation

smellthemoon
Copy link
Contributor

pr: #39812

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Feb 13, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 13, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.99%. Comparing base (9407a3c) to head (f5bd080).
Report is 1 commits behind head on 2.5.

Files with missing lines Patch % Lines
...nternal/distributed/proxy/httpserver/handler_v2.go 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39839      +/-   ##
==========================================
- Coverage   81.01%   80.99%   -0.03%     
==========================================
  Files        1417     1417              
  Lines      199610   199610              
==========================================
- Hits       161713   161670      -43     
- Misses      32222    32254      +32     
- Partials     5675     5686      +11
Components Coverage Δ
Client 79.28% <ø> (ø)
Core 69.37% <ø> (ø)
Go 82.96% <66.66%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 92.72% <66.66%> (ø)

... and 27 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Feb 13, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smellthemoon
Copy link
Contributor Author

rerun go-sdk

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

@smellthemoon smellthemoon mentioned this pull request Feb 13, 2025
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sre-ci-robot sre-ci-robot removed the lgtm label Feb 13, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@smellthemoon cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@smellthemoon
Copy link
Contributor Author

rerun cpp-unit-test

@smellthemoon
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@smellthemoon
Copy link
Contributor Author

rerun go-sdk

sre-ci-robot pushed a commit that referenced this pull request Feb 13, 2025
@smellthemoon
enhance:[2.4] return topks when search in restful v2 (#39858)
f39b45a 
pr: #39812 
2.5: #39839

Signed-off-by: lixinguo <[email protected]>
Co-authored-by: lixinguo <[email protected]>
@mergify mergify bot added the ci-passed label Feb 13, 2025
@tedxu
Copy link
Contributor

tedxu commented Feb 14, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit ba0edb8 into milvus-io:2.5 Feb 14, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@binbinlv binbinlv Awaiting requested review from binbinlv

Assignees

@tedxu tedxu

@czs007 czs007

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smellthemoon @czs007 @sre-ci-robot @tedxu