Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] ReEnqueue L0 compaction task when preCheck failed #39871

Merged

Conversation

xiaocai2333
Copy link
Contributor

issue: #39868

master pr: #39870

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 13, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (2.5@16ea4fc). Learn more about missing BASE report.
Report is 5 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/datacoord/compaction.go 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             2.5   #39871   +/-   ##
======================================
  Coverage       ?   81.00%           
======================================
  Files          ?     1417           
  Lines          ?   199606           
  Branches       ?        0           
======================================
  Hits           ?   161700           
  Misses         ?    32225           
  Partials       ?     5681           
Components Coverage Δ
Client 79.28% <ø> (?)
Core 69.37% <ø> (?)
Go 82.98% <0.00%> (?)
Files with missing lines Coverage Δ
internal/datacoord/compaction.go 70.79% <0.00%> (ø)

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaocai2333, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Feb 13, 2025

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Feb 14, 2025
@sre-ci-robot sre-ci-robot merged commit 418f971 into milvus-io:2.5 Feb 14, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants