Add node names instead of node IDs to networkx graph #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! @amva13 any additional check to perform? |
kexinhuang12345
approved these changes
Sep 24, 2024
|
Lgtm. The change will deploy in the next package release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Each node id (
x_idandy_id) is node type specific. For example, a node ID of "1" for a disease node is different from a node ID of "1" for a gene/protein node. This is (likely) not an issue for training a GNN. However, it can be an issue if users want to do network analysis on PrimeKG because the currentto_nx()function does not consider node type.Solution: Instead of adding pairs of node IDs as edges, add pairs of node names because they are unique.