Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AZTEK trajectory #234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add AZTEK trajectory #234

wants to merge 1 commit into from

Conversation

DlWAT
Copy link

@DlWAT DlWAT commented Feb 4, 2025

Addition of a function to create AZTEK trajectories

add AZTEK trajectory
@Daval-G Daval-G self-requested a review February 4, 2025 12:28
@Daval-G Daval-G added the trajectories Issues concerning Non cartesian trajectories label Feb 4, 2025
@Daval-G
Copy link
Collaborator

Daval-G commented Feb 4, 2025

@DlWAT Thank you for this contribution
Could you edit the PR title to make it more explicit, and could you provide a more detailed PR description ?
The code style seems to be old school, is it taken from somewhere and/or directly adapted from another language ?
I will try to provide a review this week, I expect that the code can be considerably reduced using native numpy functions.

@DlWAT DlWAT changed the title Update trajectory3D.py Add AZTEK trajectory Feb 4, 2025
@DlWAT
Copy link
Author

DlWAT commented Feb 4, 2025

The code was originally in C, but I translated it. I had a more python-friendly version, but I was less sure of the result.
The code originates from this github. But it only gives the end of the spokes, i.e. the max gradient (here 32768). I've added an equal distribution of points on each spoke starting from the center, and put the point coordinates between [-0.5 ; 0.5].
I can't really explain the three parameters speed, shuffle and twist, as I haven't worked on them.
https://github.com/BioMaps-MRI/AZTEK
You can find more explanation in this article : AZTEK: Adaptive zero TE k-space trajectories.

@Daval-G
Copy link
Collaborator

Daval-G commented Feb 4, 2025

Thank you for those informations. AZTEK is a trajectory we have been wanting to add for quite some time now (listed in issue #106).
Let me know to which extent you would like to contribute to its integration. For example, we usually add examples to the gallery for each new trajectory, but I can take care of that. Similarly, do you wish to make changes yourself during the review process as assignee or should we make the changes and validate them with you ? (to ensure fidelity to the paper, as from my understanding you are involved with the author team)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trajectories Issues concerning Non cartesian trajectories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants