Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[predictor] aspect ratio true by default #1279

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Aug 10, 2023

This PR:

  • change keeping the aspect ratio by default to True which will especially on images which are smaller as the default 1024x1024 improve the results

Any feedback is welcome 🤗

Ref.: #330 (already discussed with @charlesmindee)

@felixdittrich92 felixdittrich92 added type: enhancement Improvement module: models Related to doctr.models topic: text detection Related to the task of text detection labels Aug 10, 2023
@felixdittrich92 felixdittrich92 added this to the 0.7.0 milestone Aug 10, 2023
@felixdittrich92 felixdittrich92 self-assigned this Aug 10, 2023
@felixdittrich92 felixdittrich92 linked an issue Aug 10, 2023 that may be closed by this pull request
Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to modify the default value

tests/tensorflow/test_models_zoo_tf.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1279 (95c7286) into main (95857cf) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
+ Coverage   95.75%   95.76%   +0.01%     
==========================================
  Files         154      154              
  Lines        6903     6903              
==========================================
+ Hits         6610     6611       +1     
+ Misses        293      292       -1     
Flag Coverage Δ
unittests 95.76% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
doctr/models/kie_predictor/pytorch.py 100.00% <ø> (ø)
doctr/models/kie_predictor/tensorflow.py 100.00% <ø> (ø)
doctr/models/predictor/pytorch.py 100.00% <ø> (ø)
doctr/models/predictor/tensorflow.py 100.00% <ø> (ø)
doctr/models/zoo.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much ! 🚀

@felixdittrich92 felixdittrich92 merged commit 5023af9 into mindee:main Aug 11, 2023
58 checks passed
@felixdittrich92 felixdittrich92 deleted the aspect-ratio-default branch August 11, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: models Related to doctr.models topic: text detection Related to the task of text detection type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate words in OCR result
2 participants