-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ✏️ fix images on pypi #1310
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1310 +/- ##
==========================================
- Coverage 95.76% 95.75% -0.02%
==========================================
Files 154 154
Lines 6902 6902
==========================================
- Hits 6610 6609 -1
- Misses 292 293 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @odulcy-mindee 👋🏼,
thanks for the fix.
I have always tried to avoid exactly this case because with each installation you will also download the images 😅
But at the end i think without uploading the images to a file server we have no chance to fix this unfortunately :/
(In short i agree that the only way is to keep the images in a docs folder just a few style changes please 👍🏼 )
Using a git-clone, yes :/ |
Yes, sorry, it was probably a bit unclear 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Attempt to fix #783
@felixdittrich92 Unfortunately, your previous fix failed because it's a link to an asset in a GitHub Release, which behaves differently than
https://raw.githubusercontent.com/...
. GitHub Release seems to always return an answer withcontent-type=application/octet-stream
, which fools PyPi. Let's try by putting the file directly in the repo.Also, I re-addedpip install
at the top of the README.md, I think it makes sense to have it on top to show it's (now) easy to install an up-to-date version of docTR. This point is open to discussion, of course.