Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ Official docker images for docTR #1322
feat: ✨ Official docker images for docTR #1322
Changes from 25 commits
80285a3
980aeb4
f36a626
c8905a5
e977333
377fe8a
45ac49d
b2f2f6b
bc0e542
2389e68
5f2b7ed
51dd73d
491e34e
c832a84
ee08bbd
9553d16
7ab34b9
8537524
437167b
947144a
0ffaf7a
12aa2ce
162748c
43e7cc5
2849b6c
9f7c649
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixT2K I changed the cron so it should be triggered tomorrow morning. We'll see if it works or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not 100% sure that this works on publish (release)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixT2K Mmmh, actually it works for
tags
but it's not done onpublish: [released]
as I'm afraid the CI jobmetadata
fromdocker
does not handle this event. I'll double checkThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixT2K I did a test on my fork. When a draft release is created, a new tag is not created. When the release is published, the tag is created, so it triggers the
on: push: tags
event 👍There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice :)
Check notice on line 11 in Dockerfile
Codacy Production / Codacy Static Code Analysis
Dockerfile#L11
Check notice on line 11 in Dockerfile
Codacy Production / Codacy Static Code Analysis
Dockerfile#L11
Check warning on line 11 in Dockerfile
Codacy Production / Codacy Static Code Analysis
Dockerfile#L11
Check warning on line 37 in Dockerfile
Codacy Production / Codacy Static Code Analysis
Dockerfile#L37
Check notice on line 37 in Dockerfile
Codacy Production / Codacy Static Code Analysis
Dockerfile#L37
Check warning on line 57 in Dockerfile
Codacy Production / Codacy Static Code Analysis
Dockerfile#L57
Check warning on line 71 in Dockerfile
Codacy Production / Codacy Static Code Analysis
Dockerfile#L71