Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] prob computation for parseq and vitstr models #1327

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • fix prob comp for vitstr and parseq models

Any feedback is welcome 🤗

@felixdittrich92 felixdittrich92 added type: bug Something isn't working module: models Related to doctr.models framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend topic: text recognition Related to the task of text recognition labels Sep 22, 2023
@felixdittrich92 felixdittrich92 added this to the 0.7.1 milestone Sep 22, 2023
@felixdittrich92 felixdittrich92 self-assigned this Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #1327 (0a226a8) into main (8245706) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1327      +/-   ##
==========================================
+ Coverage   95.75%   95.76%   +0.01%     
==========================================
  Files         154      154              
  Lines        6902     6902              
==========================================
+ Hits         6609     6610       +1     
+ Misses        293      292       -1     
Flag Coverage Δ
unittests 95.76% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
doctr/models/recognition/parseq/pytorch.py 97.16% <100.00%> (ø)
doctr/models/recognition/parseq/tensorflow.py 97.33% <100.00%> (ø)
doctr/models/recognition/vitstr/pytorch.py 100.00% <100.00%> (ø)
doctr/models/recognition/vitstr/tensorflow.py 97.61% <100.00%> (ø)

... and 2 files with indirect coverage changes

@felixdittrich92 felixdittrich92 merged commit 9fa5e78 into mindee:main Sep 26, 2023
58 checks passed
@felixdittrich92 felixdittrich92 deleted the fix-prob-computation branch September 26, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend module: models Related to doctr.models topic: text recognition Related to the task of text recognition type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants