Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hebrew letters #1355

Merged
merged 2 commits into from
Oct 17, 2023
Merged

hebrew letters #1355

merged 2 commits into from
Oct 17, 2023

Conversation

uriva
Copy link
Contributor

@uriva uriva commented Oct 17, 2023

No description provided.

@uriva uriva mentioned this pull request Oct 17, 2023
Closed
felixT2K
felixT2K suggested changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@felixT2K felixT2K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thansk for the PR @uriva only one minor change please :)

doctr/datasets/vocabs.py Outdated Show resolved Hide resolved
@uriva
Copy link
Contributor Author

uriva commented Oct 17, 2023

ptal

@felixdittrich92 felixdittrich92 added this to the 0.7.1 milestone Oct 17, 2023
@felixdittrich92 felixdittrich92 self-assigned this Oct 17, 2023
@felixdittrich92 felixdittrich92 added topic: documentation Improvements or additions to documentation module: datasets Related to doctr.datasets topic: text recognition Related to the task of text recognition type: misc Miscellaneous ext: docs Related to docs folder labels Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1355 (d21669c) into main (e83c3ab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1355   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files         154      154           
  Lines        6910     6911    +1     
=======================================
+ Hits         6619     6620    +1     
  Misses        291      291
Flag Coverage Δ
unittests 95.78% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
doctr/datasets/vocabs.py 100.00% <100.00%> (ø)

felixdittrich92
felixdittrich92 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@felixdittrich92 felixdittrich92 merged commit 89745cf into mindee:main Oct 17, 2023
70 checks passed
@uriva uriva deleted the patch-1 branch October 17, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixT2K felixT2K felixT2K requested changes

@felixdittrich92 felixdittrich92 felixdittrich92 approved these changes

Assignees

@felixdittrich92 felixdittrich92

Labels
ext: docs Related to docs folder module: datasets Related to doctr.datasets topic: documentation Improvements or additions to documentation topic: text recognition Related to the task of text recognition type: misc Miscellaneous
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uriva @felixdittrich92 @felixT2K