Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] tf augmentations #1360

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[Fix] tf augmentations #1360

merged 1 commit into from
Oct 26, 2023

Conversation

felixT2K
Copy link
Contributor

@felixT2K felixT2K commented Oct 26, 2023 •
edited by felixdittrich92
Loading

This PR:

  • fix ToGray output channels issue
  • unify recognition augs from pt and tf (except RandomPerspective)

@felixdittrich92 felixdittrich92 added type: bug Something isn't working type: enhancement Improvement ext: references Related to references folder framework: tensorflow Related to TensorFlow backend topic: text detection Related to the task of text detection topic: text recognition Related to the task of text recognition labels Oct 26, 2023
@felixdittrich92 felixdittrich92 added this to the 0.7.1 milestone Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #1360 (22eec27) into main (bc2d3c5) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1360      +/-   ##
==========================================
- Coverage   95.80%   95.78%   -0.02%     
==========================================
  Files         154      154              
  Lines        6909     6909              
==========================================
- Hits         6619     6618       -1     
- Misses        290      291       +1
Flag Coverage Δ
unittests 95.78% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

odulcy-mindee
odulcy-mindee approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Felix !

@felixdittrich92 felixdittrich92 merged commit f22f6dd into mindee:main Oct 26, 2023
69 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odulcy-mindee odulcy-mindee odulcy-mindee approved these changes

@charlesmindee charlesmindee Awaiting requested review from charlesmindee

Assignees
No one assigned
Labels
ext: references Related to references folder framework: tensorflow Related to TensorFlow backend topic: text detection Related to the task of text detection topic: text recognition Related to the task of text recognition type: bug Something isn't working type: enhancement Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixT2K @odulcy-mindee @felixdittrich92