-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax Pillow and OpenCV version bounds. #1373
Conversation
Hi @nh2 👋, |
Codecov Report
@@ Coverage Diff @@
## main #1373 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 155 155
Lines 6952 6952
=======================================
Hits 6661 6661
Misses 291 291
Flags with carried forward coverage won't be shown. Click here to find out more. |
Please update your branch from main :) |
For Pillow, the change in commit e04e183 - chore: apply PIL major changes and increase min version specifier (mindee#1237) that does the `font.getsize()` -> `font.getbbox()` migration is definitely already available in Pillow 9.2.0, see https://pillow.readthedocs.io/en/stable/deprecations.html#font-size-and-offset-methods > Deprecated since version 9.2.0.
@felixdittrich92 Ah, sorry, that is a leftover. I had played with the OpenCV version bounds as well because on NixOS it couldn't find OpenCV. But it turned out that's because there it's called just
Done. FYI, I have packaged This might make it easy for more users to get a fully working doctr with all recursive system dependencies easily with Nix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks sounds great @nh2 👍
If your mentioned PR is merged feel free to open a follow up PR we should add it to the installation docs as option :)
@felixdittrich92 Ah yes, I just spotted from #1322 that you're interested in packaging options. Nix can be a convenient alterntaive to docker. Here's the one-liner invocation that uses the WIP commit from my PR; it drops you into a Python shell where doctr is working, with all dependencies reproducibly pinned (assuming Nix is installed): NIX_PATH=nixpkgs=https://github.com/NixOS/nixpkgs/archive/6c069433b46584559bdadcb4d74fb760308aabb0.tar.gz nix-shell -p 'python3.withPackages (ps: with ps; [ doctr ])' --run python3
|
For Pillow, the change in commit
e04e183 - chore: apply PIL major changes and increase min version specifier (#1237)
that does the
font.getsize()
->font.getbbox()
migration is definitely already available in Pillow 9.2.0, seehttps://pillow.readthedocs.io/en/stable/deprecations.html#font-size-and-offset-methods