Fixed DivisionByZeroError issue with contours having 0 height or width by excluding them #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h by excluding them.
|
Hey @samuelmathew280 👋🏼, Thanks for the PR :) I think after #1336 is merged this shouldn't happen again because we use the models segmentation map which is much more robust as the whole opencv approach, because some to small "boxes" are already filtered out before in the models post processing step |
|
Oh great! Any ETA on when that'll happen? |
|
depends on @odulcy-mindee review 😅 |
|
convert to draft until #1336 is merged to eval if the issue still exists |
|
@samuelmathew280 Could you check it again with the latest changes in main branch please ? :) |
|
Ping @samuelmathew280 :) |
|
Hey @samuelmathew280 👋 i will close this ftm feel free to re-open if you still face the error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a DivisionByZeroError when running the function to determine orientation (which calls the function get_max_width_length_ratio() while sorting, which divides the width and height), with one of the contours having 0 width or height, which caused the code to abruptly stop. So I added a quick fix to exclude any such contours, as the width and height of the contours are used later on as well.