Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typings] Replace deprecated typing with built-in types #1794

Merged

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Nov 22, 2024

This PR:

  • Replace deprecated typing types with python built-in types

@felixdittrich92 felixdittrich92 added this to the 0.11.0 milestone Nov 22, 2024
@felixdittrich92 felixdittrich92 self-assigned this Nov 22, 2024
@felixdittrich92 felixdittrich92 added module: models Related to doctr.models module: io Related to doctr.io module: utils Related to doctr.utils module: datasets Related to doctr.datasets module: transforms Related to doctr.transforms ext: api Related to api folder type: code quality Related to code quality module: contrib Related to doctr.contrib labels Nov 22, 2024
@felixdittrich92 felixdittrich92 marked this pull request as ready for review November 22, 2024 09:54
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (b53517a) to head (c7a1a87).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #1794       +/-   ##
=========================================
+ Coverage      0   96.56%   +96.56%     
=========================================
  Files         0      165      +165     
  Lines         0     7892     +7892     
=========================================
+ Hits          0     7621     +7621     
- Misses        0      271      +271     
Flag Coverage Δ
unittests 96.56% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@felixdittrich92 felixdittrich92 merged commit 72bed41 into mindee:main Nov 25, 2024
69 checks passed
@felixdittrich92 felixdittrich92 deleted the replace-deprecated-typings branch November 25, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: api Related to api folder module: contrib Related to doctr.contrib module: datasets Related to doctr.datasets module: io Related to doctr.io module: models Related to doctr.models module: transforms Related to doctr.transforms module: utils Related to doctr.utils type: code quality Related to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants