Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Replace in deprecation dropped httpx.AsyncClient app arg #1802

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

felixT2K
Copy link
Contributor

@felixT2K felixT2K commented Nov 30, 2024

This PR:

  • Replace httpx.AsyncClient removed app=app with transport=ASGITransport(app=app)

@felixdittrich92 felixdittrich92 added this to the 0.11.0 milestone Nov 30, 2024
@felixdittrich92 felixdittrich92 self-assigned this Nov 30, 2024
@felixdittrich92 felixdittrich92 added ext: tests Related to tests folder ext: api Related to api folder type: misc Miscellaneous labels Nov 30, 2024
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.54%. Comparing base (2711df4) to head (c0f5330).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1802   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files         165      165           
  Lines        7892     7892           
=======================================
  Hits         7619     7619           
  Misses        273      273           
Flag Coverage Δ
unittests 96.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 merged commit 2dbabbb into mindee:main Nov 30, 2024
70 checks passed
@felixT2K felixT2K deleted the fix-deprecated-testclient branch November 30, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: api Related to api folder ext: tests Related to tests folder type: misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants