Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Fix tensorflow build dep #1807

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • the extra "[and-cuda]" is only available on linux
  • for windows only WSL2 (linux) supports direct GPU support - where our logic would match - for native windows the extra does not exist same for MacOS

ref.: https://www.tensorflow.org/install/pip#windows-native

@felixdittrich92 felixdittrich92 added type: bug Something isn't working topic: build Related to dependencies and build framework: tensorflow Related to TensorFlow backend os: windows Involving Windows users labels Dec 3, 2024
@felixdittrich92 felixdittrich92 added this to the 0.11.0 milestone Dec 3, 2024
@felixdittrich92 felixdittrich92 self-assigned this Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.55%. Comparing base (2dbabbb) to head (973024f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1807      +/-   ##
==========================================
+ Coverage   96.54%   96.55%   +0.01%     
==========================================
  Files         165      165              
  Lines        7892     7892              
==========================================
+ Hits         7619     7620       +1     
+ Misses        273      272       -1     
Flag Coverage Δ
unittests 96.55% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@felixdittrich92 felixdittrich92 merged commit c8ec392 into mindee:main Dec 3, 2024
70 checks passed
@felixdittrich92 felixdittrich92 deleted the build-dep-fix branch December 3, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: tensorflow Related to TensorFlow backend os: windows Involving Windows users topic: build Related to dependencies and build type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants