Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix vocabs and add corresponding test case #1813

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • fix duplications in hindi and vietnamese vocabs
  • update docs
  • add corresponding test case

@felixdittrich92 felixdittrich92 added type: bug Something isn't working topic: documentation Improvements or additions to documentation ext: tests Related to tests folder module: datasets Related to doctr.datasets labels Dec 4, 2024
@felixdittrich92 felixdittrich92 added this to the 0.11.0 milestone Dec 4, 2024
@felixdittrich92 felixdittrich92 self-assigned this Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (9b6dea3) to head (e5e9d9b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1813   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files         165      165           
  Lines        7929     7929           
=======================================
  Hits         7660     7660           
  Misses        269      269           
Flag Coverage Δ
unittests 96.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 merged commit 48873e0 into mindee:main Dec 4, 2024
70 checks passed
@felixdittrich92 felixdittrich92 deleted the minor-test-update branch December 4, 2024 13:00
sarjil77 pushed a commit to sarjil77/doctr that referenced this pull request Dec 9, 2024
changes with vocab and documentation dec 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder module: datasets Related to doctr.datasets topic: documentation Improvements or additions to documentation type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants