Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ specify output_dir in reference scripts #1820

Merged
merged 2 commits into from
Dec 17, 2024
Merged

feat: ✨ specify output_dir in reference scripts #1820

merged 2 commits into from
Dec 17, 2024

Conversation

odulcy-mindee
Copy link
Collaborator

No description provided.

felixT2K
felixT2K suggested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@felixT2K felixT2K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things :)

references/detection/train_tensorflow.py Show resolved Hide resolved
references/detection/train_pytorch_ddp.py Outdated Show resolved Hide resolved
references/classification/train_pytorch_character.py Outdated Show resolved Hide resolved
@odulcy-mindee
Copy link
Collaborator Author

@felixT2K Thanks for the catch

felixdittrich92
felixdittrich92 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx ☺️ lgtm

@felixdittrich92 felixdittrich92 added this to the 0.11.0 milestone Dec 17, 2024
@felixdittrich92 felixdittrich92 added type: enhancement Improvement ext: references Related to references folder topic: text detection Related to the task of text detection topic: text recognition Related to the task of text recognition topic: character classification Related to the task of character classification labels Dec 17, 2024
@odulcy-mindee odulcy-mindee merged commit 5c145a3 into mindee:main Dec 17, 2024
66 checks passed
@odulcy-mindee odulcy-mindee deleted the feat_output_dir branch December 17, 2024 15:55
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (13893ec) to head (4cc0fb6).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1820      +/-   ##
==========================================
- Coverage   96.63%   96.62%   -0.02%     
==========================================
  Files         165      165              
  Lines        7929     7929              
==========================================
- Hits         7662     7661       -1     
- Misses        267      268       +1
Flag Coverage Δ
unittests 96.62% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixdittrich92 felixdittrich92 felixdittrich92 approved these changes

@felixT2K felixT2K Awaiting requested review from felixT2K

Assignees
No one assigned
Labels
ext: references Related to references folder topic: character classification Related to the task of character classification topic: text detection Related to the task of text detection topic: text recognition Related to the task of text recognition type: enhancement Improvement
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@odulcy-mindee @felixdittrich92 @felixT2K