Skip to content
This repository has been archived by the owner on Jul 24, 2019. It is now read-only.

Fix to support multiple instances #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brutuscat
Copy link

Fix to support multiple instances adding a wrapper context for toolbar's bindings

So if u wrap your editors in different containers, u can have multiple instances of it.

@martin-g
Copy link

👍

@jvdh
Copy link

jvdh commented Oct 1, 2013

How do I make this work? I've wrapped all editor divs in seperate div's and start a instance of the plugin for each editor. Edits become apparent in all editors though. :(

@brutuscat
Copy link
Author

Maybe u are not using this code. Try getting the file from my branch
directly. What u are reporting is the behavior WITHOUT my fix

On Tue, Oct 1, 2013 at 3:54 PM, jvdh [email protected] wrote:

How do I make this work?
I've wrapped all editor divs in seperate div's and start a instance of the
plugin for each editor. Edits become apparent in all editors though. :(


Reply to this email directly or view it on GitHubhttps://github.com//pull/103#issuecomment-25450932
.

Mauro Asprea

E-Mail: [email protected]
Mobile: +34 654297582
Skype: mauro.asprea

@jvdh
Copy link

jvdh commented Oct 1, 2013

Hi Mauro,

Hm, ok. Got the right script now. But only the last field is getting
changed even though I focus/edit a different field. Is there a different
way target the elements with the plugin?

2013/10/1 Mauro Asprea [email protected]

Maybe u are not using this code. Try getting the file from my branch
directly. What u are reporting is the behavior WITHOUT my fix

On Tue, Oct 1, 2013 at 3:54 PM, jvdh [email protected] wrote:

How do I make this work?
I've wrapped all editor divs in seperate div's and start a instance of
the
plugin for each editor. Edits become apparent in all editors though. :(


Reply to this email directly or view it on GitHub<
https://github.com/mindmup/bootstrap-wysiwyg/pull/103#issuecomment-25450932>

.

Mauro Asprea

E-Mail: [email protected]
Mobile: +34 654297582
Skype: mauro.asprea


Reply to this email directly or view it on GitHubhttps://github.com//pull/103#issuecomment-25452293
.

@brutuscat
Copy link
Author

No idea really. It worked for me after I fixed it in the first try and I'm
working with several editors at once... sorry... Maybe if u do a jsfiddle
thing we could help u out.

On Tue, Oct 1, 2013 at 4:49 PM, jvdh [email protected] wrote:

Hi Mauro,

Hm, ok. Got the right script now. But only the last field is getting
changed even though I focus/edit a different field. Is there a different
way target the elements with the plugin?

2013/10/1 Mauro Asprea [email protected]

Maybe u are not using this code. Try getting the file from my branch
directly. What u are reporting is the behavior WITHOUT my fix

On Tue, Oct 1, 2013 at 3:54 PM, jvdh [email protected] wrote:

How do I make this work?
I've wrapped all editor divs in seperate div's and start a instance of
the
plugin for each editor. Edits become apparent in all editors though.
:(


Reply to this email directly or view it on GitHub<

https://github.com/mindmup/bootstrap-wysiwyg/pull/103#issuecomment-25450932>

.

Mauro Asprea

E-Mail: [email protected]
Mobile: +34 654297582
Skype: mauro.asprea


Reply to this email directly or view it on GitHub<
https://github.com/mindmup/bootstrap-wysiwyg/pull/103#issuecomment-25452293>

.


Reply to this email directly or view it on GitHubhttps://github.com//pull/103#issuecomment-25455956
.

Mauro Asprea

E-Mail: [email protected]
Mobile: +34 654297582
Skype: mauro.asprea

@jvdh
Copy link

jvdh commented Oct 1, 2013

Ok, but first I'll clean up my messy code and try again. Thanks again.

2013/10/1 Mauro Asprea [email protected]

No idea really. It worked for me after I fixed it in the first try and I'm
working with several editors at once... sorry... Maybe if u do a jsfiddle
thing we could help u out.

On Tue, Oct 1, 2013 at 4:49 PM, jvdh [email protected] wrote:

Hi Mauro,

Hm, ok. Got the right script now. But only the last field is getting
changed even though I focus/edit a different field. Is there a different
way target the elements with the plugin?

2013/10/1 Mauro Asprea [email protected]

Maybe u are not using this code. Try getting the file from my branch
directly. What u are reporting is the behavior WITHOUT my fix

On Tue, Oct 1, 2013 at 3:54 PM, jvdh [email protected]
wrote:

How do I make this work?
I've wrapped all editor divs in seperate div's and start a instance
of
the
plugin for each editor. Edits become apparent in all editors though.
:(


Reply to this email directly or view it on GitHub<

https://github.com/mindmup/bootstrap-wysiwyg/pull/103#issuecomment-25450932>

.

Mauro Asprea

E-Mail: [email protected]
Mobile: +34 654297582
Skype: mauro.asprea


Reply to this email directly or view it on GitHub<

https://github.com/mindmup/bootstrap-wysiwyg/pull/103#issuecomment-25452293>

.


Reply to this email directly or view it on GitHub<
https://github.com/mindmup/bootstrap-wysiwyg/pull/103#issuecomment-25455956>

.

Mauro Asprea

E-Mail: [email protected]
Mobile: +34 654297582
Skype: mauro.asprea


Reply to this email directly or view it on GitHubhttps://github.com//pull/103#issuecomment-25457522
.

steveathon referenced this pull request in steveathon/bootstrap-wysiwyg Apr 27, 2014
…ap-wysiwyg

This combines the #68 change where FF throws an error and #103 where it supports multiple instances thanks to @brutuscat

# By Mauro Asprea
# Via Mauro Asprea
* 'fix-multiple-instances' of github.com:brutuscat/bootstrap-wysiwyg:
  Fix to support multiple instances adding a wrapper context for toolbar's bindings

Conflicts:
	bootstrap-wysiwyg.js
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants