Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for enabling Native Wayland support and troubleshooting XWayland issues #103

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

Morxemplum
Copy link
Contributor

This pull request helps document the issues that can arise from running the client under XWayland, and how to compile the game launcher with native Wayland support. I feel like the documentation does a much better job than #82 when it comes to this purpose, so merging this request should close that one.

I am aware of the progress being made to try and get both the game launcher and the qt launcher to run under SDL3 by default, but considering how long the pull request has been open and I do not have any idea when this pull request will merge, it's important that we address the issue in the meantime.

Once that pull request does merge, the documentation can be further updated by removing the instructions and streamlining the troubleshooting process.

@ChristopherHX
Copy link
Member

👍 While I don't agree that SDL3 prefers xwayland over wayland. QT does some weird decision by itself having it's own variable to prefer x over wayland or vice versa.

In the flatpak using GLFW this is at least true with the version selected during build

@ChristopherHX ChristopherHX merged commit 7f2ff64 into minecraft-linux:main Dec 3, 2024
2 checks passed
@Morxemplum
Copy link
Contributor Author

Morxemplum commented Dec 3, 2024

I don't think I mentioned that SDL3 is the reason that Xwayland is preferred, but I did mention that if you don't have SDL3, you can't run the client under Wayland natively. If you try to unset DISPLAY on a game launcher without Wayland support, it will refuse to launch and kick you back to the Qt Launcher.


Once you have the game launcher built with Wayland support, you will need to
force the client to run under Wayland, as it will still default to running
under Xwayland. This is done by unsetting the `DISPLAY` environment variable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This point is about this statement, which implies sdl3 prefers x over wayland if both are available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants