chore: add go fuzz support #39
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katcipis
reviewed
Mar 31, 2022
| return | ||
| } | ||
|
|
||
| _ = markdown.Render(&w, def) |
There was a problem hiding this comment.
hmm maybe one property to check here is that if parsing worked, calling render should always write something on w if the return err is nil (not 100% sure this is always true, so maybe @thiesen can confirm). Like if the render suceeded, I think it always renders something, there is no scenario for empty rendering on terradoc I think 🤔 . But this can be done later anyway.
| @@ -1,18 +1,18 @@ | |||
| module github.com/mineiros-io/terradoc | |||
|
|
|||
| go 1.17 | |||
| go 1.18 | |||
There was a problem hiding this comment.
Does terradoc now require at least go 1.18 ? 🤔
There was a problem hiding this comment.
I just added everything I had and committed.. this is not needed. With this change, I was testing if go1.17 still builds..
I'm going to mark this PR as draft.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not ideal but already found a bug so adding here.