Handle invalid param2 in presets.lua #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't we place the check closer to the cause of the issue? |
|
We could validate the param2 values, but that would be more complicated. I see the current approach as similar to checking for NaN after doing a numeric calculation. Really the root cause is some other mod changing param2 values willy-nilly, but Mesecons has no control of that. |
SmallJoker
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #610.
To test, load up devtest with Mesecons and homedecor_lighting. Place a Mesecons lever and, separately, a
homedecor:glowlight_small_cube_14. Use the param2 tool to set the lever's param2 to 25 and the light's param2 to 6. Try turning on the lever. Then try turning on the light using a switch adjacent to it. The game should not crash.