This repository has been archived by the owner on May 13, 2024. It is now read-only.
Add tests for image loaders #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numberZero
changed the title
sfan5
approved these changes
Oct 2, 2023
|
Can you recheck if any new tests work now? |
|
Updated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds simple tests for BMP, PNG and TGA image loaders. Image dimensions and content are tested.
Image size is deliberately odd, to capture bugs related to unusual image sizes (apparently BMP loader has this exact problem with 16bpp images).
I commented out tests that fail currently to reduce noise. These should be enabled on fixing underlying problems.
I only added testing to the linux-gl build as the tests look platform-independent currently. Not sure whether that’s a good idea though.