Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

[not wip] This PR has imploded #257

Closed
wants to merge 44 commits into from
Closed

[not wip] This PR has imploded #257

wants to merge 44 commits into from

Conversation

jordan4ibanez
Copy link
Contributor

WIP. Does what it says on the tin

@jordan4ibanez jordan4ibanez changed the title [wip] Gut Every Unused Format Out Of Irrlicht [wip] Gut Every Unused/Deprecated/Long Forgotten Format Out Of Irrlicht Nov 29, 2023
@rollerozxa
Copy link
Member

3d models are no more, we can finally go home again

@jordan4ibanez jordan4ibanez changed the title [wip] Gut Every Unused/Deprecated/Long Forgotten Format Out Of Irrlicht [wip] Gut Every Unused/Deprecated/Long Forgotten Format Out Of Irrlicht. Also completely gut the file writer source code. Nov 29, 2023
Totally unused in Minetest
@jordan4ibanez jordan4ibanez changed the title [wip] Gut Every Unused/Deprecated/Long Forgotten Format Out Of Irrlicht. Also completely gut the file writer source code. [wip] Begin implementing Josiah's GLTF PR with a blank slate. Nov 29, 2023
@jordan4ibanez jordan4ibanez changed the title [wip] Begin implementing Josiah's GLTF PR with a blank slate. [wip] GLTF PR is now up to date, continue from last point. Nov 29, 2023
@rubenwardy
Copy link
Member

Why?

@jordan4ibanez
Copy link
Contributor Author

Why?

Too many things pointing towards each other, too many things stepping on each other's toes. We start with the most complex loader first, GLTF. Then we put the OBJ loader back into the engine with the required changes.
Doing it this way stops literally everything else from getting in the way

@rollerozxa
Copy link
Member

The Irrlicht model format loader system is modular, you shouldn't need to do this just to get GLTF working. I assumed you were going to move it into Minetest and register them as external loaders but I don't know what the purpose would be of juggling around the loaders inside of IrrlichtMt like this.

@jordan4ibanez
Copy link
Contributor Author

The Irrlicht model format loader system is modular, you shouldn't need to do this just to get GLTF working. I assumed you were going to move it into Minetest and register them as external loaders but I don't know what the purpose would be of juggling around the loaders inside of IrrlichtMt like this.

I'm probably going to have to change animation code to work with GLTF, I'm going into the modular loading system and modifying it and I don't need to be modifying 2 loaders at the same time, one being deprecated, to bring in a new one

@jordan4ibanez
Copy link
Contributor Author

So we're back to where we left of, excellent
screenshot_20231129_063426

@JosiahWI
Copy link
Contributor

I have rebased #200.

@jordan4ibanez jordan4ibanez changed the title [wip] GLTF PR is now up to date, continue from last point. [not wip] This PR has imploded Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants