This repository has been archived by the owner on May 13, 2024. It is now read-only.
[no sq] Reformat the code (adopted) #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
find -type f | # list all regular files grep -E '\.(h|cpp|mm)$' | # filter for source files grep -v '/mt_' | # filter out generated files grep -v '/vendor/' | # and vendored GL grep -v '/test/image_loader_test.cpp' | # and this file (has giant literals arrays) xargs -n 1 -P $(nproc) clang-format -i # reformat everything Co-authored-by: numzero <[email protected]>
Desour
commented
Mar 20, 2024
Found via: `rg --multiline "=\n\t*\{\n"`
sfan5
reviewed
Mar 21, 2024
sfan5
approved these changes
Mar 21, 2024
|
I noticed, that there are still tabs after non-tab characters. While we want to allow this for code samples in comments (see #248 (comment)), in other cases, it's kinda nasty. |
find -type f | # list all regular files grep -E '\.(h|cpp|mm)$' | # filter for source files grep -v '/mt_' | # filter out generated files grep -v '/vendor/' | # and vendored GL xargs -n 1 -P $(nproc) ./replace_non_leading_tabs.lua # reformat everything
|
Removed the non-leading tabs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adoption of: #248
(Don't squash. PRs that need to be rebased should rebase on the "Move source/Irrlicht/ to src/" commit separately.)