Add Dockerfile and workflow to publish image #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
reviewed
Jun 23, 2024
| @@ -0,0 +1,26 @@ | |||
| ARG DOCKER_IMAGE=alpine:3.19 | |||
There was a problem hiding this comment.
3.19 is used by the Minetest Engine, so I though it would be nice to keep them the same. It would not harm if you decide to upgrade anyways.
sfan5
reviewed
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Dockerfilewhich compilesminetestmapperand puts it into a Docker image. Additionally, a workflow file is added to publish the images toghcr.io/minetest/minetestmapperonmasterchange.This PR is ready for review.