Feature/to cache pipeline #111

Mee-gu · 2018-11-07T06:01:01Z

Cache ShaderModule, RenderPass and RenderPipeline for reuse

get latest code

…etal-support * 'metal-support' of github.com:Mee-gu/new-renderer: use MTLPixelFormatDepth32Float_Stencil8 instead since it has better compatibility use MTLPixelFormatDepth32Float_Stencil8 instead since it has better compatibility 【Feature】add test case (minggo#109)

… code looks clean

Feature/to cache pipeline (minggo#110)

cocos/math/HashAlgorithm.h

src/backend/BlendState.cpp

src/backend/BlendState.h

src/backend/StringUtils.hpp

src/backend/Texture.cpp

src/backend/metal/DeviceMTL.h

src/backend/Device.h

src/backend/Texture.h

minggo · 2018-11-09T02:38:31Z

src/backend/metal/DeviceMTL.mm

@@ -102,4 +178,37 @@
    return new (std::nothrow) RenderPipelineMTL(_mtlDevice, descriptor);
 }

+size_t DeviceMTL::findRenderPipelineInCache(const RenderPipelineDescriptor& descriptor)
+{


Why not just return RenderPipeline*?

src/backend/metal/RenderPipelineMTL.mm

…0/std::numeric_limits<size_t>::max().

Mee-gu · 2018-11-12T14:13:21Z

src/backend/metal/RenderPipelineMTL.mm

@@ -248,7 +247,7 @@ MTLVertexFormat toMTLVertexFormat(VertexFormat vertexFormat)
        info += StringUtils::BlendFactor2String(blendDescriptor.destinationAlphaBlendFactor);
    }

-    return HashAlgorithm::PJWHash(info.c_str(), info.length());
+    return std::hash<std::string>{}(info);


Use std::hash since the collision probability approaching 1.0/std::numeric_limits<size_t>::max().

minggo · 2018-11-13T01:17:26Z

src/backend/Device.h

    // Create a auto released depth stencil state.
    virtual DepthStencilState* createDepthStencilState(const DepthStencilDescriptor& descriptor) = 0;
    // Create a auto released blend state.
    virtual BlendState* createBlendState(const BlendDescriptor& descriptor) = 0;
    // Create a render pipeline, not auto released.
    virtual RenderPipeline* newRenderPipeline(const RenderPipelineDescriptor& descriptor) = 0;
-
+    // Cache RenderPipeline for reuse
+//    virtual RenderPipeline* cacheRenderPipeline(const RenderPipelineDescriptor& descriptor) = 0;


Please remove unneeded codes.

Mee-gu and others added 7 commits October 25, 2018 10:03

Merge pull request #1 from minggo/metal-support

a8389b3

get latest code

【BugFix】release the textures before cleaning the vertor

1ac15dd

【Feature】use releaseTextures() to remove duplicated code and make the…

4afa565

… code looks clean

Merge pull request #3 from minggo/metal-support

3cbbc63

Feature/to cache pipeline (minggo#110)

【Feature】caching for RenderPipeline, test succeed on MacOS

b2b2297

【Feature】caching for renderPipeline, test succeed on iOS

b6b62b4