Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows node setup #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bobsira
Copy link

@bobsira bobsira commented Sep 20, 2024

This pull request introduces several enhancements to the Hyper-V driver and Docker Machine library to support Windows Server VHD images. Key changes include:

Hyper-V Driver Modifications:

  • Added WindowsVHDUrl and OS fields to the driver configuration.
  • Updated the NewDriver function to initialize these fields with default values.
  • Enhanced PreCreateCheck and Create functions to handle downloading and copying of Windows Server VHD images, based on the guest OS type.
  • Modified various Hyper-V commands to support Windows Server configurations, such as setting up VM processors, memory, and hard disk drives specifically for Windows.

Docker Machine Library Enhancements:

  • Updated method signatures to include a guest OS parameter.
  • Added the DefineGuest function to differentiate guest OS.
  • Introduced utility functions to manage Windows VHD images, including DownloadVHD, CopyWindowsIsoToMachineDir, and UpdateVHDCache.

New Download Handling:

  • Added download_vhd.go for multi-part downloading of large VHD files with progress tracking.

SSH Command Handling:

  • Added checks to prevent SSH command execution on Windows guest OS, as SSH is not supported in this environment.

These changes aim to provide robust support for Windows Server deployments in Docker Machine, enhancing compatibility and flexibility for users managing virtual machines on Hyper-V.

@bobsira bobsira marked this pull request as ready for review January 1, 2025 09:22
@bobsira bobsira changed the title [DRAFT] Windows node setup Windows node setup Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant