Use correct target path during mirroring objects #4807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if we dont use absolute paths in mirror command, absolute path of
source gets appended to the target path and so in destination object gets
mirrored to wrong prefix / path.
For example say source object path is `/tmp/source/prefix/a.txt` and mirror
command executed from `/tmp` dir as `mc mirror --json --watch source xyz`,
the object in target gets mirrored to location `xyz/tmp/source/prefix/a.txt`.
Also any new file created gets copied properly though.
```
mc mirror --json --watch source/ xyz/
{
"status": "success",
"source": "/tmp/source/prefix/a.txt",
"target": "xyz/tmp/source/prefix/a.txt",
"size": 0,
"totalCount": 1,
"totalSize": 0
}
{
"status": "success",
"source": "/tmp/source/b.txt",
"target": "xyz/b.txt",
"size": 0,
"totalCount": 2,
"totalSize": 0
}
```
With the fix now after running the command `mc mirror --json --watch source xyz`
the object would correctly get copied to location `/tmp/xyz/prefix/a.txt` as below
```
{
"status": "success",
"source": "/tmp/source/prefix/a.txt",
"target": "xyz/prefix/a.txt",
"size": 0,
"totalCount": 2,
"totalSize": 0
}
{
"status": "success",
"source": "/tmp/source/b.txt",
"target": "xyz/b.txt",
"size": 0,
"totalCount": 1,
"totalSize": 0
}
{
"status": "success",
"source": "/tmp/source/c.txt",
"target": "xyz/c.txt",
"size": 0,
"totalCount": 3,
"totalSize": 0
}
```
Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
|
This seems to be only for filesystem to filesystem? @shtripat |
|
Let me take a through look at this; I would say most likley there is a regression somewhere that caused this. |
Yes |
Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
harshavardhana
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set correct target path for mirrored objects
Motivation and Context
Issue: #4806
Currently if we don't use absolute paths in mirror command, absolute path of source gets appended to the target path and so in destination object gets mirrored to wrong prefix / path.
For example say source object path is
/tmp/source/prefix/a.txtand mirror command executed from/tmpdir asmc mirror --json --watch source xyz, the object in target gets mirrored to locationxyz/tmp/source/prefix/a.txt.With the fix now after running the command
mc mirror --json --watch source xyzthe object would correctly get copied to location/tmp/xyz/prefix/a.txtas belowCommunity Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
How to test this PR?
Refer issue# #4806
Usual mirror with absolute paths should work as is.
Types of changes
Checklist:
commit-idorPR #here)