Rework entire code for correctness and potential bug fixes (#111)

minio · Mar 16, 2024 · 765ec24 · 765ec24
1 parent 009f2f5
commit 765ec24
Show file tree

Hide file tree

Showing 81 changed files with 2,466 additions and 1,727 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -46,7 +46,7 @@ ENDIF (${CMAKE_BINARY_DIR} STREQUAL ${CMAKE_SOURCE_DIR})
 SET(requiredlibs)
 
 IF(CMAKE_COMPILER_IS_GNUCC)
-  set(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} -Werror")
+  set(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} -Werror -Wall -Wextra -Wconversion")
   IF(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 8.0 AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 9.0 AND NOT MINGW)
     list(APPEND requiredlibs stdc++fs)
   ENDIF()

diff --git a/examples/BucketExists.cc b/examples/BucketExists.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/ComposeObject.cc b/examples/ComposeObject.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/CopyObject.cc b/examples/CopyObject.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/DeleteBucketEncryption.cc b/examples/DeleteBucketEncryption.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/DeleteBucketLifecycle.cc b/examples/DeleteBucketLifecycle.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/DeleteBucketNotification.cc b/examples/DeleteBucketNotification.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/DeleteBucketPolicy.cc b/examples/DeleteBucketPolicy.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/DeleteBucketReplication.cc b/examples/DeleteBucketReplication.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/DeleteBucketTags.cc b/examples/DeleteBucketTags.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/DeleteObjectLockConfig.cc b/examples/DeleteObjectLockConfig.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/DeleteObjectTags.cc b/examples/DeleteObjectTags.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/DisableObjectLegalHold.cc b/examples/DisableObjectLegalHold.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/DownloadObject.cc b/examples/DownloadObject.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/EnableObjectLegalHold.cc b/examples/EnableObjectLegalHold.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/GetBucketEncryption.cc b/examples/GetBucketEncryption.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/GetBucketLifecycle.cc b/examples/GetBucketLifecycle.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/GetBucketNotification.cc b/examples/GetBucketNotification.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/GetBucketPolicy.cc b/examples/GetBucketPolicy.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/GetBucketReplication.cc b/examples/GetBucketReplication.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/GetBucketTags.cc b/examples/GetBucketTags.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/GetBucketVersioning.cc b/examples/GetBucketVersioning.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/GetObject.cc b/examples/GetObject.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/GetObjectLockConfig.cc b/examples/GetObjectLockConfig.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/GetObjectProgress.cc b/examples/GetObjectProgress.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/GetObjectRetention.cc b/examples/GetObjectRetention.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/GetObjectTags.cc b/examples/GetObjectTags.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/GetPresignedObjectUrl.cc b/examples/GetPresignedObjectUrl.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/GetPresignedPostFormData.cc b/examples/GetPresignedPostFormData.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/IsObjectLegalHoldEnabled.cc b/examples/IsObjectLegalHoldEnabled.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/ListBuckets.cc b/examples/ListBuckets.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/ListObjects.cc b/examples/ListObjects.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/ListenBucketNotification.cc b/examples/ListenBucketNotification.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/MakeBucket.cc b/examples/MakeBucket.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/PutObject.cc b/examples/PutObject.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/PutObjectProgress.cc b/examples/PutObjectProgress.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/RemoveBucket.cc b/examples/RemoveBucket.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/RemoveObject.cc b/examples/RemoveObject.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/RemoveObjects.cc b/examples/RemoveObjects.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/SelectObjectContent.cc b/examples/SelectObjectContent.cc
@@ -16,7 +16,7 @@
 #include "client.h"
 #include "select.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/SetBucketEncryption.cc b/examples/SetBucketEncryption.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/SetBucketLifecycle.cc b/examples/SetBucketLifecycle.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/SetBucketNotification.cc b/examples/SetBucketNotification.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");
 

diff --git a/examples/SetBucketPolicy.cc b/examples/SetBucketPolicy.cc
@@ -15,7 +15,7 @@
 
 #include "client.h"
 
-int main(int argc, char* argv[]) {
+int main() {
   // Create S3 base URL.
   minio::s3::BaseUrl base_url("play.min.io");