Skip to content

Commit

Permalink
Use ubuntu-24.04 for linter
Browse files Browse the repository at this point in the history
Signed-off-by: Bala.FA <[email protected]>
  • Loading branch information
balamurugana committed May 15, 2024
1 parent c3ce2fa commit ad1966c
Show file tree
Hide file tree
Showing 2 changed files with 49 additions and 33 deletions.
33 changes: 0 additions & 33 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,39 +16,6 @@ permissions:
contents: read

jobs:
coding-style:
name: "Coding Style & Version Check"
runs-on: ubuntu-latest

steps:
- name: Checkout minio-cpp
uses: actions/checkout@v4
with:
path: "minio-cpp"

- name: "Python"
uses: actions/setup-python@v5
with:
python-version: "3.x"

- name: Install dependencies if Ubuntu
run: |
wget --quiet -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
echo 'deb http://apt.llvm.org/focal/ llvm-toolchain-focal-18 main' | sudo tee -a /etc/apt/sources.list
sudo apt-get -qy update
sudo apt-get -qy install clang-format-18
clang-format-18 --version
- name: Version Check
shell: bash
working-directory: minio-cpp
run: python check-version.py

- name: Coding Style Check
shell: bash
working-directory: minio-cpp
run: CLANG_FORMAT=clang-format-18 ./check-style.sh

build:
strategy:
fail-fast: false
Expand Down
49 changes: 49 additions & 0 deletions .github/workflows/linters.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
name: Linters

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]

# This ensures that previous jobs for the PR are canceled when the PR is
# updated.
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref }}
cancel-in-progress: true

permissions:
contents: read

jobs:
coding-style:
name: "Coding Style & Version Check"
runs-on: ubuntu-24.04

steps:
- name: Checkout minio-cpp
uses: actions/checkout@v4
with:
path: "minio-cpp"

- name: "Python"
uses: actions/setup-python@v5
with:
python-version: "3.x"

- name: Install dependencies
run: |
# sudo apt -qy update
# sudo apt -qy upgrade
sudo apt -qy install clang-format-18
clang-format-18 --version
- name: Version Check
shell: bash
working-directory: minio-cpp
run: python check-version.py

- name: Coding Style Check
shell: bash
working-directory: minio-cpp
run: CLANG_FORMAT=clang-format-18 ./check-style.sh

0 comments on commit ad1966c

Please sign in to comment.