Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved C++ headers to minio-cpp subdirectory #123

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

kobalicek
Copy link
Contributor

  • Use #include <minio-cpp/header.h> to include minio-cpp now
  • Header files have consistent guards that don't start with _
  • Added a SPDX license identifier to each source and header file

CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@piotr-topnotch piotr-topnotch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some prefix is vital, we can't afford to have #include <client.h> in user code. The user might be using several other libraries unknown to us and there might be clashing OS headers as well. I have no opinion on whether it should be hyphenated or not.

@kobalicek
Copy link
Contributor Author

@balamurugana Can you review again?

I have changed minio-cpp to miniocpp as required although I think it's ugly...

  * Use #include <miniocpp/header.h> to include minio-cpp now
  * Header files have consistent guards that don't start with _
  * Added a SPDX license identifier to each source and header file
  * Use clang-format-18 to format the source code
@kobalicek kobalicek merged commit 238f465 into main Mar 26, 2024
4 checks passed
@kobalicek kobalicek deleted the include_hygiene branch March 26, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants