Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include files cleanup and minor API changes #124

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Include files cleanup and minor API changes #124

merged 1 commit into from
Mar 28, 2024

Conversation

kobalicek
Copy link
Contributor

  • use namespace::subnamespace where applicable
  • make minio::error::SUCCESS declared only once
  • make more constructors explicit (minio::error)
  • moved constants that seem private into .cc files
  • added .clang-format file to enforce more formatting rules

@kobalicek
Include files cleanup and minor API changes
aedd42a 
  * use namespace::subnamespace where applicable
  * make minio::error::SUCCESS declared only once
  * make more constructors explicit (minio::error)
  * moved constants that seem private into .cc files
  * added .clang-format file to enforce more formatting rules
@kobalicek kobalicek merged commit 1e5f140 into main Mar 28, 2024
4 checks passed
@kobalicek kobalicek deleted the include_cleanup branch March 28, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balamurugana balamurugana balamurugana approved these changes

@piotr-topnotch piotr-topnotch Awaiting requested review from piotr-topnotch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobalicek @balamurugana