Enhanced CMakeLists.txt to create a proper export #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobalicek
force-pushed
the
cmake_enhancements
branch
from
a9bc829
to
3ab7f8c
Compare
At the moment miniocpp-config.cmake specifies dependencies, but when it's actually used by a client it requires that client resolves the dependencies himself - which means that the client would have to use find_package() to find everything that minio-cpp uses. This fixes the problem. It creates miniocpp-targets.cmake, which is a file generated by cmake, and also creates miniocpp-config.cmake, which adds the required find_package() commands to the cmake and then includes miniocpp-targets.cmake, which provides the targets. This change finalizes the integration of minio-cpp with both cmake and vcpkg.
kobalicek
force-pushed
the
cmake_enhancements
branch
from
3ab7f8c
to
2d1e45a
Compare
balamurugana
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment miniocpp-config.cmake specifies dependencies, but when it's actually used by a client it requires that client resolves the dependencies himself - which means that the client would have to use find_package() to find everything that minio-cpp uses.
This fixes the problem. It creates miniocpp-targets.cmake, which is a file generated by cmake, and also creates miniocpp-config.cmake, which adds the required find_package() commands to the cmake and then includes miniocpp-targets.cmake, which provides the targets.
This change finalizes the integration of minio-cpp with both cmake and vcpkg.