Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of ports inside the URI #156

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix parsing of ports inside the URI #156

wants to merge 2 commits into from

Commits on Jul 12, 2024

  1. attempt parsing of port only if colon was found 

    without this change, urls like 5.my.s3.cluster were misinterpreted and
  the '5' parsed as the port of the url.

Bug:
* the getline() function puts the entire input string into the
  destination string, if the delimiter was not found.
  This leads to the entire host string being fed to the stoi()
  function to parse the port.

Fix:
* applied suggestion by @balamurugana
    Florian Kaiser committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    513a808 View commit details
    Browse the repository at this point in the history

  2. https flag is not mirrored from Url() to BaseUrl 

    this flag assignement was removed in:
  minio#111

I don't know if it was removed intentional, but without it
the BaseUrl.https flag only reflects the state of how BaseUrl was
constructed with.
    Florian Kaiser committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    8cded87 View commit details
    Browse the repository at this point in the history