Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignV4: trim leading/trailing spaces in header value #163

Merged
merged 1 commit into from
Aug 21, 2024
Merged

SignV4: trim leading/trailing spaces in header value #163

merged 1 commit into from
Aug 21, 2024

Conversation

balamurugana
Copy link
Member

No description provided.

harshavardhana
harshavardhana requested changes Aug 17, 2024
View reviewed changes
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test for this?

@kobalicek
Copy link
Contributor

@harshavardhana Can we unblock and merge this one even without an additional test?

I think it's clear what it does, and I think we need a new release as the current minio-cpp in vcpkg doesn't work.

@harshavardhana harshavardhana merged commit c9d3c25 into minio:main Aug 21, 2024
4 checks passed
@harshavardhana
Copy link
Member

sure merged @kobalicek

@balamurugana balamurugana deleted the SignV4-trim-leading-trailing-spaces-in-header-value branch August 26, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balamurugana @kobalicek @harshavardhana