Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check bucket locking status before clean up #285

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Sep 13, 2023

This would fix #284, this checks the bucket ObjectLockConfiguration, and if one is present, sets the proper RemoveObjectsOptions field GovernanceBypass, as it can't normally be passed if the bucket is not "locked".

This is my first time with Go, so sorry in advance if the code is not following best practices or is not idiomatic.

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 7a904a2 into minio:master Sep 13, 2023
9 checks passed
@bentsku bentsku deleted the fix-cleanup-governance-bypass branch September 13, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean up: always sending x-amz-bypass-governance-retention
3 participants